Merge pull request #147 from jk-cluster/feat/renovate-nginx-84-wording

renovate: name the nginx alpine check in #84 accurately
This commit is contained in:
jklein authored and GitHub committed 2026-08-24 10:52:35 +00:00
commit d85ff72dad
2 files changed
+4 -3

No files matched your search

+1 -1
View File
@@ -70,7 +70,7 @@ What Renovate keeps current:
Each chart renders its main image as `<repo>:{{ .Chart.AppVersion }}` — repository in the template, version in `Chart.yaml`. Renovate cannot join two files, so the mapping lives in `renovate.json5`, one block per chart. It is deliberately *not* a `# renovate:` comment inside each `Chart.yaml`: that would touch all chart directories and force a version bump plus a publish per chart for a pure comment change. Charts whose tags carry a flavour or date suffix (`apache-tika`, `minecraft-server`, `rss-bridge`, `teamspeak-server`) override `versioning` in their block; the reasoning sits next to each one.
One dependency is constrained beyond its versioning: **nginx** (the Synapse delegation sidecar) is limited to **even minors** via `allowedVersions`. nginx numbers its release branches by minor — even is stable, odd is mainline — and the chart belongs on stable. Patch updates inside the stable branch still flow through normally. The constraint tolerates a variant suffix (`1.30.4-alpine`) on purpose: docker versioning only ever offers candidates carrying the current tag's suffix, so a suffix-blind constraint would silently freeze nginx the day the sidecar moves to a slimmer base image (#84) — no error, no warning.
One dependency is constrained beyond its versioning: **nginx** (the Synapse delegation sidecar) is limited to **even minors** via `allowedVersions`. nginx numbers its release branches by minor — even is stable, odd is mainline — and the chart belongs on stable. Patch updates inside the stable branch still flow through normally. The constraint tolerates a variant suffix (`1.30.4-alpine`) on purpose: docker versioning only ever offers candidates carrying the current tag's suffix, so a suffix-blind constraint would silently freeze nginx the day the sidecar moves to a slimmer base image — a switch to `1.30.4-alpine` that #84 has commissioned a check on — with no error and no warning.
Not managed: `ci/**` (install-test fixtures pin throwaway infrastructure to major lines on purpose) and `template-chart/**` (placeholder image). A consequence worth knowing: `ci/matrix-synapse/fixtures.yaml` pins a Synapse image that Renovate will not follow — bump it by hand when the chart moves a major.
+3 -2
View File
@@ -108,8 +108,9 @@
matchDatasources: ["docker"],
matchPackageNames: ["nginx", "library/nginx", "docker.io/library/nginx"],
// Even minor: any minor whose last digit is even, so 1.30.x passes and
// 1.31.x does not. The trailing (-.+)? is load-bearing: #84 proposes
// moving this sidecar to a slimmer base image, and with a variant tag
// 1.31.x does not. The trailing (-.+)? is load-bearing: #84 commissioned
// a check on moving this sidecar to 1.30.4-alpine (outcome open, to be
// done alongside the seccompProfile PR), and with a variant tag
// like 1.30.4-alpine docker versioning only ever offers candidates
// carrying the same suffix. Without the optional suffix, every one of
// them would fail this filter and nginx would silently stop receiving