helm-charts/CLAUDE.md

CLAUDE.md

This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.

Working on issues — mandatory workflow

The main Claude session acts as the task manager and does not implement issues itself:

1. Plan first, get approval: The manager presents a plan for the issue and waits for the user's explicit approval. No implementation before approval.
2. Document the final plan on the issue: Once approved, the plan is posted as a comment on the issue before implementation starts (skip if the issue body already contains the full plan; later decisions go there as comments too).
3. Delegate implementation: After approval, the manager launches a dedicated development agent. The agent implements the issue completely on its own branch and opens a PR.
4. PR comment handling by the agent: After opening the PR, the development agent watches it for review comments. New comments are addressed automatically (code changes, reply on the thread), and addressed threads are marked as resolved.
5. Agent lifetime: The development agent terminates itself once its PR has been merged (or closed).
6. Only after the PR has been merged by the user may work on the next issue begin. The user merges; never merge yourself.
7. After the merge, verify the linked issue was closed (auto-close via "Fixes #n"); close it manually if not. Gitea auto-closes on the same keywords, but only for an issue in the same repository — a migrated issue whose number changed is closed by hand.

Additional rules for all commits, PRs, issues, and comments:

• Do not add a Co-Authored-By trailer and do not append "Generated with Claude Code" footers.
• Commits must be signed. Verify the signature before opening the PR; if op-ssh-sign fails, stop and report rather than pushing unsigned work.

Which forge, and with which tool

The repository is moving from github.com to the Gitea instance JLab-Git (#225). The move is not finished, so both are live and the steps below differ by where the work happens. README, "Where this repo lives", holds the measured differences between the two CIs; this section holds only what changes about the workflow.

• Remotes are named github and JLab-Git — there is no origin. Say which one you mean; git push without a remote is ambiguous here.
• Today the merge flow still runs on GitHub. Issues, pull requests and merges happen there until the maintainer switches Actions off and turns on the mirror. Until then, do not push to JLab-Git/main: with publish workflows armed on both sides, two CIs publish into the same registry, and that registry accepts a re-upload of an existing version silently, replacing the artifact (#160). Pushing a branch to Gitea is fine — only main triggers a publish.
• gh only as op plugin run -- gh, tea only as op plugin run -- tea. A bare gh falls back to the wrong identity. Every call costs a 1Password confirmation, so bundle them and never poll.
• After the move: no merge queue. Gitea has none. Its place is taken by auto-merge on green checks — the PR is armed once and merges itself when the required checks pass. The manager still decides whether to arm it; rule 6 above is unchanged: the user merges, and an agent never merges its own PR.
• Issue numbers will not survive the move. Gitea renumbers, and issues and PRs share one counter. A #n written today keeps pointing at the GitHub issue; ci/migrate-issues-to-gitea.sh writes the old→new mapping but deliberately rewrites nothing.
• Renovate is already running on the Gitea side, and not from this repo. A shared jlab-renovate-bot instance serves the other repositories there and has this one enrolled; it reads our renovate.json5 and its postUpgradeTasks hook is allow-listed (both verified on its first run). Do not add a Renovate workflow here — a second runner against the same repo means duplicate PRs and two schedulers rewriting each other's branches. README, "Renovate on Gitea", has the evidence.

Keep the docs current

• Changes to this issue workflow always go into this CLAUDE.md file.
• General repository information (charts, CI pipelines, conventions, tooling) always lives in README.md. Any PR that changes repo-wide behavior must update README.md in the same PR.
• Runtime verification of chart changes is done in a local, throwaway k3d cluster (k3d is installed on the maintainer's machine): stub CRD for OnePasswordItem, dummy secrets, throwaway infrastructure (postgres/redis) where needed.

What this repo is

A collection of self-made Helm charts, one directory per chart, published to a private, classic (index-based) Helm registry by CI (GitHub Actions today, Gitea Actions after #225; the workflow files are read by both unchanged) — an HTTP POST of the packaged .tgz, not an OCI helm push; the target URL and its credentials live in 1Password and never in this repository. Validation happens on three levels: locally with Helm, in the PR pipeline (validate-charts.yml: strict lint, package, version-bump check), and in the PR install-test stage (k3d, fixtures under ci/ — see README):

helm lint --strict <chart-name>
helm template <chart-name> --set ingress.domain=example.com --set ingress.clusterIssuer=letsencrypt   # render locally; required values vary per chart

Creating a new chart

Copy template-chart/ and replace every xxx placeholder — in file names (templates/xxx.deployment.yaml → templates/<app>.deployment.yaml), in Chart.yaml, in the values.yaml keys and their .Values.xxx.* references inside templates, and in values.schema.json (both the values paths and the xxx. helper prefixes). The schema and the null-safe fallback helpers come with the template but their content is chart-specific — adapt them along the six points of the README section "Values that must not lie", and validate the result against the chart's real bundle values, not only against its defaults. Then wire up CI:

1. Add .github/workflows/publish-<chart-name>.yml (copy an existing one, e.g. publish-outline.yml) — it triggers on pushes to main touching <chart-name>/** and calls the reusable publish-helm-chart.yml.
2. Add the chart name to the chart-name choice list in .github/workflows/change-app-version.yml.
3. Add install-test fixtures under ci/<chart-name>/ (test-values.yaml, fixtures.yaml) or an entry with justification in ci/excluded-charts.txt — the PR install-test fails if both are missing.
4. Add a customManagers block for the chart's main image in renovate.json5 (one per chart, since the image repository lives in the template and the version in Chart.yaml) — without it Renovate never updates that chart's app version. See README section "Dependency updates (Renovate)".

Versioning scheme

Chart.yaml versions follow version: <chart-semver>+up<appVersion> (e.g. 1.4.0+up1.9.2), with appVersion matching the suffix (dashes in the app version are normalized to dots in the suffix). Any push to main touching a chart directory publishes that chart, so the version must be bumped in the same change.

Semver conventions for the chart part:

• Patch: bug fixes without behavior or values-schema change; plain app-version updates.
• Minor: additive, backward-compatible changes (new optional values with unchanged defaults).
• Major: runtime behavior changes or breaking values changes (e.g. probes, security hardening, computed limits, values that become required).

App-version updates go through PRs (so the validate and install-test pipelines run), not through the change-app-version.yml dispatch workflow (which commits directly to main and bypasses both). For app major jumps, update stepwise: first to the last release of the old major line (own PR, merge, publish), then to the newest major.

Chart conventions

The binding style guide for all current and future charts lives in README.md ("Chart style guidelines"); template-chart/ is the reference implementation. Compact summary:

• Resources named {{ .Release.Name }}-{{ .Chart.Name }}-<kind>; template files <app>.<kind>.yaml; stateful apps use a StatefulSet (<app>.sfs.yaml). Documented exception: historical PVC names stay (renames would orphan data); StatefulSet renames only with a --cascade=orphan migration note in a major PR.
• Main image tag from {{ .Chart.AppVersion }}; auxiliary/sidecar/init images pinned via values and reviewed on app-update rounds.
• Ingress: ingress.domain and ingress.clusterIssuer required without defaults; ingress.className defaults to nginx; optional ingress.annotations merged with the cert-manager annotation; TLS secret tls-<release>-<chart>-ingress. Documented exception: homeassistant keeps its flexible upstream ingress style (className default nginx).
• Secrets are 1Password OnePasswordItem CRs: values expose secrets.<name>SecretRef holding an op:// item path; the operator materializes the Kubernetes Secret.
• Config changes must restart the workload (#82): every pod template consuming a ConfigMap carries checksum/config: {{ include (print $.Template.BasePath "/<chart>.configmap.yaml") . | sha256sum }} (one line per ConfigMap). Without it a changed ConfigMap restarts nothing — subPath mounts are never refreshed and apps read config only at start. Adding it to an existing chart is a major bump. Secrets from OnePasswordItem cannot be hashed (Helm never sees their content); charts mounting them document the limitation in values.yaml.
• Every container offers an additive env block rendered through tpl with value, secretKeyRef, and configMapKeyRef forms.
• Hardening: automountServiceAccountToken: false, non-root, readOnlyRootFilesystem: true, caps dropped, allowPrivilegeEscalation: false; contexts values-configurable (securityContext.pod / securityContext.container); writable paths as emptyDirs; image-forced deviations MUST be documented with a comment in the chart's values.yaml.
• Probes: liveness/readiness/startup on every workload (exception: paperless consume CronJob), values-configurable with calibrated defaults.
• Resources: requests as values defaults; limits auto-computed by the _helpers.tpl helper (limitFactor default 3; no CPU limits unless set explicitly).
• Replicas per workload (explicit 0 allowed) plus a chart-global scaleDown flag that overrides them.
• icon: mandatory in every Chart.yaml; helm lint --strict without findings; CI fixtures under ci/<chart>/ or a justified exclusion.
• Chart dependencies are admissible but expensive (the former "no dependencies" rule fell with #214; ytdlp-web-player is the only chart using one). A dependency has to be optional and off by default via condition:, and upstream's chart is consumed as it comes — where its defaults fall short of these conventions, that is documented in our values.yaml, never patched. The price to know before adding the next one: a subchart is invisible to everything downstream that watches Helm release versions, so a new upstream version — a security fix included — reaches a cluster only when the outer chart is republished (Renovate's built-in helmv3 manager plus ci/renovate-bump-chart.sh is the whole safety net, and it belongs in a comment at the pinned version); and every helm command exits 1 while charts/ is unfilled, which is why ci/helm-dependencies.sh runs before lint, package, render and install — including the render test that covers all charts on every PR. Full rules and the rest of the cost: README, "Chart dependencies".