README.md gains a comprehensive 'Chart style guidelines' section - the binding end state of the conventions overhaul (#32, batches 0-4) for all current and future charts: naming (incl. the PVC-name exception and the StatefulSet migration pattern), versioning scheme and semver rules, image pinning, the ingress standard (domain + clusterIssuer strictly required without defaults, className default nginx, annotations merge, TLS secret name, homeassistant exception), security hardening with mandatory documentation of deviations, probes, the auto-limits scheme, the secrets.<name>SecretRef convention, tpl-rendered env blocks, scaling, and the icon/lint/CI-fixture/no-dependencies rules. The Versioning section now points there and documents that app-version updates go through PRs. CLAUDE.md's conventions section is aligned as a compact summary referencing the README guide.
6.6 KiB
CLAUDE.md
This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
Working on issues — mandatory workflow
The main Claude session acts as the task manager and does not implement issues itself:
- Plan first, get approval: The manager presents a plan for the issue and waits for the user's explicit approval. No implementation before approval.
- Document the final plan on the issue: Once approved, the plan is posted as a comment on the GitHub issue before implementation starts (skip if the issue body already contains the full plan; later decisions go there as comments too).
- Delegate implementation: After approval, the manager launches a dedicated development agent. The agent implements the issue completely on its own branch and opens a PR.
- PR comment handling by the agent: After opening the PR, the development agent watches it for review comments. New comments are addressed automatically (code changes, reply on the thread), and addressed threads are marked as resolved.
- Agent lifetime: The development agent terminates itself once its PR has been merged (or closed).
- Only after the PR has been merged by the user may work on the next issue begin. The user merges; never merge yourself.
- After the merge, verify the linked issue was closed (auto-close via "Fixes #n"); close it manually if not.
Additional rules for all commits, PRs, issues, and comments:
- Do not add a
Co-Authored-Bytrailer and do not append "Generated with Claude Code" footers.
Keep the docs current
- Changes to this issue workflow always go into this CLAUDE.md file.
- General repository information (charts, CI pipelines, conventions, tooling) always lives in README.md. Any PR that changes repo-wide behavior must update README.md in the same PR.
- Runtime verification of chart changes is done in a local, throwaway k3d cluster (k3d is installed on the maintainer's machine): stub CRD for
OnePasswordItem, dummy secrets, throwaway infrastructure (postgres/redis) where needed.
What this repo is
A collection of self-made Helm charts, one directory per chart, published to a private OCI registry via GitHub Actions. Validation happens on three levels: locally with Helm, in the PR pipeline (validate-charts.yml: strict lint, package, version-bump check), and in the PR install-test stage (k3d, fixtures under ci/ — see README):
helm lint --strict <chart-name>
helm template <chart-name> --set ingress.domain=example.com --set ingress.clusterIssuer=letsencrypt # render locally; required values vary per chart
Creating a new chart
Copy template-chart/ and replace every xxx placeholder — in file names (templates/xxx.deployment.yaml → templates/<app>.deployment.yaml), in Chart.yaml, and in the values.yaml keys and their .Values.xxx.* references inside templates. Then wire up CI:
- Add
.github/workflows/publish-<chart-name>.yml(copy an existing one, e.g.publish-outline.yml) — it triggers on pushes tomaintouching<chart-name>/**and calls the reusablepublish-helm-chart.yml. - Add the chart name to the
chart-namechoice list in.github/workflows/change-app-version.yml. - Add install-test fixtures under
ci/<chart-name>/(test-values.yaml,fixtures.yaml) or an entry with justification inci/excluded-charts.txt— the PR install-test fails if both are missing.
Versioning scheme
Chart.yaml versions follow version: <chart-semver>+up<appVersion> (e.g. 1.4.0+up1.9.2), with appVersion matching the suffix (dashes in the app version are normalized to dots in the suffix). Any push to main touching a chart directory publishes that chart, so the version must be bumped in the same change.
Semver conventions for the chart part:
- Patch: bug fixes without behavior or values-schema change; plain app-version updates.
- Minor: additive, backward-compatible changes (new optional values with unchanged defaults).
- Major: runtime behavior changes or breaking values changes (e.g. probes, security hardening, computed limits, values that become required).
App-version updates go through PRs (so the validate and install-test pipelines run), not through the change-app-version.yml dispatch workflow (which commits directly to main and bypasses both). For app major jumps, update stepwise: first to the last release of the old major line (own PR, merge, publish), then to the newest major.
Chart conventions
The binding style guide for all current and future charts lives in README.md ("Chart style guidelines"); template-chart/ is the reference implementation. Compact summary:
- Resources named
{{ .Release.Name }}-{{ .Chart.Name }}-<kind>; template files<app>.<kind>.yaml; stateful apps use a StatefulSet (<app>.sfs.yaml). Documented exception: historical PVC names stay (renames would orphan data); StatefulSet renames only with a--cascade=orphanmigration note in a major PR. - Main image tag from
{{ .Chart.AppVersion }}; auxiliary/sidecar/init images pinned via values and reviewed on app-update rounds. - Ingress:
ingress.domainandingress.clusterIssuerrequiredwithout defaults;ingress.classNamedefaults tonginx; optionalingress.annotationsmerged with the cert-manager annotation; TLS secrettls-<release>-<chart>-ingress. Documented exception: homeassistant keeps its flexible upstream ingress style (className defaultnginx). - Secrets are 1Password
OnePasswordItemCRs: values exposesecrets.<name>SecretRefholding anop://item path; the operator materializes the Kubernetes Secret. - Every container offers an additive
envblock rendered throughtplwithvalue,secretKeyRef, andconfigMapKeyRefforms. - Hardening:
automountServiceAccountToken: false, non-root,readOnlyRootFilesystem: true, caps dropped,allowPrivilegeEscalation: false; contexts values-configurable (securityContext.pod/securityContext.container); writable paths as emptyDirs; image-forced deviations MUST be documented with a comment in the chart'svalues.yaml. - Probes: liveness/readiness/startup on every workload (exception: paperless consume CronJob), values-configurable with calibrated defaults.
- Resources: requests as values defaults; limits auto-computed by the
_helpers.tplhelper (limitFactordefault 3; no CPU limits unless set explicitly). - Replicas per workload (explicit
0allowed) plus a chart-globalscaleDownflag that overrides them. icon:mandatory in everyChart.yaml;helm lint --strictwithout findings; CI fixtures underci/<chart>/or a justified exclusion; no chart dependencies (charts/directories are empty).