Validate Helm Charts / Detect changed charts (pull_request) Successful in 4s
Validate Helm Charts / Resource quantities (pull_request) Successful in 14s
Validate Helm Charts / Selector match (pull_request) Successful in 14s
Validate Helm Charts / HTTPRoute match (pull_request) Successful in 14s
Validate Helm Charts / Build freesailarr (pull_request) Successful in 7s
Validate Helm Charts / Build outline (pull_request) Successful in 7s
Validate Helm Charts / Build paperless-ngx (pull_request) Successful in 8s
Validate Helm Charts / Build zipline (pull_request) Successful in 8s
Validate Helm Charts / Build calibre-web-automated (pull_request) Successful in 7s
Validate Helm Charts / Trivy config calibre-web-automated (pull_request) Successful in 19s
Validate Helm Charts / Trivy config freesailarr (pull_request) Successful in 24s
Validate Helm Charts / Trivy config outline (pull_request) Successful in 17s
Validate Helm Charts / Trivy config paperless-ngx (pull_request) Successful in 19s
Validate Helm Charts / Trivy config zipline (pull_request) Successful in 19s
Install-test / Install-test calibre-web-automated (pull_request) Successful in 2m11s
Install-test / Install-test freesailarr (pull_request) Successful in 3m55s
Install-test / Install-test outline (pull_request) Successful in 2m44s
Install-test / Install-test paperless-ngx (pull_request) Successful in 3m52s
Install-test / Install-test zipline (pull_request) Successful in 2m6s
Validate Helm Charts / Install-test (pull_request) Successful in 14m50s
Group 2 of the #114 sweep: the charts whose behaviour hangs off an nginx annotation - calibre-web-automated, outline, paperless-ngx, zipline (proxy-body-size) and freesailarr (rewrite-target). Each gets the form the pilot (cyberchef, PR #115) fixed and group 1 (PR #116) repeated: an httpRoute block off by default, a template rendering ONLY an HTTPRoute with parentRefs - no Gateway, no gatewayClassName, no Certificate, no implementation-specific policy object - render aborts on both modes at once (naming both value paths), on an empty parentRefs and on a missing hostname, empty hostnames meaning [ingress.domain], a schema entry closed against unknown keys with an open parentRef definition, and a NOTES.txt that names the active mode and what the mode costs. Minor, additive, defaults unchanged: `helm template` with each chart's CI values is byte-identical to origin/main for all five. The upload limit is DOCUMENTED, not rebuilt (decision 2 of the issue). The Gateway API knows no body size; a policy object would bind the chart to one implementation. So the Gateway branch of NOTES.txt says, per chart and in the chart's own terms, that the value is NOT ENFORCED and names where to set it: an e-book library (calibre), an upload service (zipline), the web-UI half of the document intake while the consume directory keeps no limit at all (paperless), and the open #12 pair (outline). Four findings that were not in the plan, each argued in the file it changes: freesailarr gated freesailarr.sharedIngressApps on ingress.enabled, and that list is read by the <APP>__SERVER__URLBASE variables as well as by the routing objects. In Gateway mode it would have come out EMPTY while the route served radarr, sonarr and prowlarr under their prefixes: UrlBase unset, assets and API calls linked at the host root, broken UI behind a Ready pod. The helper's two guards (seerr/mediathekarr only at "/", no duplicate paths) would have gone unenforced there too. Fixed with freesailarr.published (ingress.enabled OR httpRoute.enabled) - the same shape as sure.publishedOverTls in group 1, and identical to ingress.enabled while httpRoute.enabled is false. Measured: on origin/main with ingress.enabled: false the render emits ZERO URLBASE variables; with this change in Gateway mode it emits three. paperless-ngx was the last chart in the repository rendering its Ingress UNCONDITIONALLY. Without an ingress.enabled switch there is no second value path for the mutual-exclusion abort to name, and the Ingress plus its unconditional required() on clusterIssuer would have kept rendering in Gateway mode - a value demanded for nothing, which is issue #114's "Folge 1" and README guideline 12. The switch was added, defaulting to true, so the render is unchanged. paperless-ngx PAPERLESS_URL had no required() of its own: it relied on the Ingress template's, which stops firing the moment the Ingress is switchable. With httpRoute.hostnames set and ingress.domain empty it would have rendered "https://" and refused every login POST as a CSRF failure. It now carries its own required(), naming what the value is for. calibre-web-automated claimed, in values.yaml and in its schema, that ingress.domain is read nowhere but in the Ingress template. The HTTPRoute reads it, so the claim now holds only while both modes are off. Corrected rather than left standing - the same correction garage needed in group 1. freesailarr is where the Gateway API is LESS machinery than what it replaces, not a translation of it. rewrite-target applies per Ingress OBJECT, so qBittorrent (no base path, prefix must be stripped) needed a second Ingress on the shared host, which then had to repeat the first object's TLS secret name, omit the cert-manager annotation conditionally so only one Certificate is requested, and match an ImplementationSpecific regex path for the rewrite's capture group. A URLRewrite filter applies per RULE: one route, one rule per app, the filter on qBittorrent's rule, a plain PathPrefix. All four crutches gone. It is also the only chart without httpRoute.hostnames - it has no ingress.domain either, and a chart-global hostname list could not say which of the ten apps it belonged to, so the hostnames stay in ingress.host and <app>.ingress.host. CI: one render overlay per chart under ci/httproute/, so the assertion is not vacuum-green - ci/run-httproute-match-test.sh goes from 20 held assertions over 10 charts to 36 over 15. freesailarr's overlay moves bazarr onto a host of its own, so the shared-host route AND the per-app route are both rendered; without that the per-app branch would be exercised by nothing. The install-test fixtures stay in Ingress mode: the install runs one configuration per chart, cyberchef already pays that price against the real Gateway-API CRDs, and for paperless-ngx that fixture is the only install of the valkey-subchart path anywhere. README also carries a stale figure fixed here: the HTTPRoute test was still documented at the pilot's 4 assertions over 2 charts, although group 1 had taken it to 20 over 10. Not proven, by construction: that traffic flows. No Gateway controller runs in CI. Not run locally either: k3d, Docker, Trivy. The Gateway branch of NOTES.txt is EXECUTED by the render test (a template error in it fails the job, verified) but its text is printed by no pipeline stage - helm template does not emit notes, and the install-test installs in Ingress mode. Part of #114
212 lines
12 KiB
Plaintext
212 lines
12 KiB
Plaintext
{{- $replicas := include "zipline.replicas" (dict "scaleDown" .Values.scaleDown "replicas" .Values.zipline.replicas) -}}
|
|
{{- $res := fromYaml (include "zipline.effectiveResources" .Values.zipline.resources) -}}
|
|
{{- $eph := index ($res.limits | default dict) "ephemeral-storage" | default "the computed ephemeral-storage limit" -}}
|
|
{{- $startup := fromYaml (include "zipline.startupProbe" .Values.zipline.startupProbe) -}}
|
|
{{- $budget := "" -}}
|
|
{{- if and (kindIs "float64" $startup.periodSeconds) (kindIs "float64" $startup.failureThreshold) -}}
|
|
{{- $budget = printf "%.0f seconds" (mulf $startup.periodSeconds $startup.failureThreshold) -}}
|
|
{{- end -}}
|
|
{{- $httpRoute := .Values.httpRoute | default dict -}}
|
|
{{- $hostnames := $httpRoute.hostnames | default list -}}
|
|
{{- if not $hostnames -}}
|
|
{{- $hostnames = list .Values.ingress.domain -}}
|
|
{{- end -}}
|
|
Zipline {{ .Chart.AppVersion }} — release {{ .Release.Name }} in namespace {{ .Release.Namespace }}.
|
|
|
|
{{- if .Values.ingress.enabled }}
|
|
|
|
ACCESS — INGRESS MODE (ingress.enabled: true, httpRoute.enabled: false)
|
|
https://{{ .Values.ingress.domain }}
|
|
|
|
The certificate is requested by cert-manager through the "{{ .Values.ingress.clusterIssuer }}"
|
|
cluster issuer. Until it has been issued the browser shows a warning; follow it with
|
|
|
|
kubectl -n {{ .Release.Namespace }} get certificate tls-{{ .Release.Name }}-{{ .Chart.Name }}-ingress
|
|
{{- else if $httpRoute.enabled }}
|
|
|
|
ACCESS — GATEWAY MODE (httpRoute.enabled: true, ingress.enabled: false)
|
|
{{- range $hostnames }}
|
|
https://{{ . }}
|
|
{{- end }}
|
|
|
|
This release renders an HTTPRoute ({{ .Release.Name }}-{{ .Chart.Name }}-httproute) and NOTHING
|
|
else of the routing path — no Gateway, no class, no Certificate. Three things
|
|
therefore belong to the cluster and not to this chart, and if any is missing
|
|
the address above does not answer:
|
|
|
|
1. The Gateway-API CRDs. Without them this install would have failed.
|
|
2. The Gateway named in httpRoute.parentRefs
|
|
{{- range $httpRoute.parentRefs }}
|
|
{{ .name }}{{ if .namespace }} in namespace {{ .namespace }}{{ end }}{{ if .sectionName }}, listener {{ .sectionName }}{{ end }}
|
|
{{- end }}
|
|
must exist AND its listener must allow routes from this namespace
|
|
({{ .Release.Namespace }}) in allowedRoutes. A rejected attachment shows
|
|
up only in the route's status:
|
|
|
|
kubectl -n {{ .Release.Namespace }} get httproute {{ .Release.Name }}-{{ .Chart.Name }}-httproute -o yaml
|
|
|
|
Read status.parents[].conditions — "Accepted: True" and
|
|
"ResolvedRefs: True" is a working attachment. An empty status means no
|
|
controller has looked at the route at all.
|
|
3. The TLS certificate for the hostname, on the Gateway's listener.
|
|
ingress.clusterIssuer is NOT used in this mode and is not required: the
|
|
chart renders no Certificate, so there is no
|
|
tls-{{ .Release.Name }}-{{ .Chart.Name }}-ingress secret and nothing for cert-manager to do.
|
|
|
|
ingress.domain is still required in this mode and is {{ .Values.ingress.domain }}: it is also
|
|
CORE_DEFAULT_DOMAIN, the host Zipline puts into every share link it hands
|
|
out, and the route does not replace it. If you set httpRoute.hostnames to a
|
|
name ingress.domain does not carry, the route publishes one host while every
|
|
link the app generates names another — set both together.
|
|
|
|
ingress.annotations is inert in this mode: the Gateway API has no annotation
|
|
channel. For this chart that includes the upload cap — see below.
|
|
{{- else }}
|
|
|
|
ACCESS — NEITHER INGRESS NOR HTTPROUTE
|
|
ingress.enabled and httpRoute.enabled are both false, so this release is not
|
|
published: no Ingress, no HTTPRoute and no certificate;
|
|
ingress.clusterIssuer is not needed. ingress.domain still is: it is also
|
|
CORE_DEFAULT_DOMAIN, the host Zipline puts into every share link it hands
|
|
out. Reach the instance inside the cluster with
|
|
|
|
kubectl -n {{ .Release.Namespace }} port-forward svc/{{ .Release.Name }}-{{ .Chart.Name }}-service 8080:80
|
|
|
|
and open http://localhost:8080 — but every link the app generates will still
|
|
point at https://{{ .Values.ingress.domain }}/, which nothing in this release serves.
|
|
{{- end }}
|
|
{{ if eq $replicas "0" }}
|
|
SCALED TO ZERO
|
|
{{ if .Values.scaleDown }}scaleDown: true{{ else }}zipline.replicas: 0{{ end }} — the StatefulSet runs with replicas: 0, so the endpoint
|
|
above does not answer until you set it back and upgrade again. The uploads
|
|
PVC, both Secrets and the Service{{ if .Values.ingress.enabled }} and Ingress stay in place, so no data is
|
|
lost and the certificate is not re-issued.{{ else if $httpRoute.enabled }} and HTTPRoute stay in place, so no data is
|
|
lost — the route then resolves to a Service with no endpoints and the Gateway
|
|
answers its own error.{{ else }} stay in place, so no data is lost.{{ end }}
|
|
{{ end }}
|
|
THE FIRST VISITOR CHOOSES THE ADMINISTRATOR
|
|
Against an empty database Zipline has no users, and it sends every visitor
|
|
to its setup page to name the super administrator and its password; the
|
|
endpoint behind that page refuses to run a second time once an account
|
|
exists. Whoever reaches the URL first therefore owns this instance. Do the
|
|
setup right after the first rollout, not the next morning. Against a
|
|
database that already carries a Zipline schema the step is skipped and the
|
|
normal login appears.
|
|
|
|
SECRETS — WHAT THE TWO 1PASSWORD ITEMS MUST CONTAIN
|
|
The operator copies an item's FIELDS into the Kubernetes Secret, one key per
|
|
field name, and this chart reads exactly one key from each. The field names
|
|
therefore have to match to the letter:
|
|
|
|
secrets.databaseSecretRef → {{ .Values.secrets.databaseSecretRef }}
|
|
field "connection-url" → DATABASE_URL, a full PostgreSQL URL such as
|
|
postgresql://zipline:password@postgres.example.com:5432/zipline
|
|
The chart deploys no database — that server has to exist already and be
|
|
reachable from this namespace.
|
|
|
|
secrets.ziplineSecretRef → {{ .Values.secrets.ziplineSecretRef }}
|
|
field "server-secret" → CORE_SECRET, which signs sessions and tokens.
|
|
Generate one with: openssl rand -base64 32
|
|
|
|
A field spelled differently yields a Secret without that key. The pod then
|
|
hangs in CreateContainerConfigError while the Secret itself exists, so it
|
|
looks as if the operator had done its job. What it actually delivered:
|
|
|
|
kubectl -n {{ .Release.Namespace }} get secret {{ .Release.Name }}-{{ .Chart.Name }}-db-secret -o jsonpath='{.data}'
|
|
|
|
Pointing a ref at a DIFFERENT item rolls the pod; changing the value INSIDE
|
|
the same item does not — Helm never sees that content, so the rendered
|
|
StatefulSet is unchanged and nothing restarts:
|
|
|
|
kubectl -n {{ .Release.Namespace }} rollout restart statefulset/{{ .Release.Name }}-{{ .Chart.Name }}-sfs
|
|
|
|
Note that a new CORE_SECRET logs every user out.
|
|
|
|
STARTUP RUNS THE DATABASE MIGRATIONS
|
|
Zipline migrates its schema on start, before it serves anything. The startup
|
|
probe covers that window{{ if $budget }} ({{ $budget }}){{ end }} and keeps liveness and readiness off
|
|
until it is through; if a migration needs longer, the kubelet kills the
|
|
container and the next attempt begins the migration again. A migration that
|
|
fails looks like CrashLoopBackOff and only the log says why:
|
|
|
|
kubectl -n {{ .Release.Namespace }} logs statefulset/{{ .Release.Name }}-{{ .Chart.Name }}-sfs
|
|
|
|
helm rollback returns the chart to the previous app version; the database
|
|
does not come back with it, because the schema was migrated in place. Take a
|
|
database backup before an app-version upgrade, not after.
|
|
|
|
WHAT A READY POD PROVES — AND WHAT AN OUTAGE LOOKS LIKE
|
|
Readiness and startup use /api/healthcheck, which also checks the database,
|
|
so Ready here does mean "server up, database answering". Liveness
|
|
deliberately uses "/" instead, so a database outage cannot restart the pod.
|
|
Know the resulting picture in advance: during such an outage the container
|
|
keeps running and stays quiet, the pod goes NotReady, its endpoint is
|
|
dropped{{ if .Values.ingress.enabled }} and the Ingress answers 503{{ else if $httpRoute.enabled }} and the Gateway answers its own error for the route{{ end }} — and nothing in the pod's log or
|
|
restart count points at the database. Look there first.
|
|
|
|
TWO DIFFERENT CEILINGS APPLY TO AN UPLOAD
|
|
The app-side limit is pinned by the chart at UPLOADER_ADMIN_LIMIT=500mb and
|
|
is not exposed as a value.
|
|
{{- if .Values.ingress.enabled }}
|
|
In front of it the Ingress caps the request body at config.maxUploadFileSize
|
|
({{ .Values.config.maxUploadFileSize }}), so that is the ceiling that actually bites: anything larger is
|
|
rejected by ingress-nginx with 413 before Zipline sees a byte of it. Raise
|
|
config.maxUploadFileSize to move it.
|
|
{{- else if $httpRoute.enabled }}
|
|
IN GATEWAY MODE config.maxUploadFileSize ({{ .Values.config.maxUploadFileSize }}) IS NOT ENFORCED. The chart
|
|
renders it into nginx.ingress.kubernetes.io/proxy-body-size, and the Gateway
|
|
API has NO counterpart — it knows no body size at all, that is
|
|
implementation-specific policy — so this chart deliberately renders no policy
|
|
object, which would bind it to one implementation. Whatever limit the Gateway
|
|
enforces is the ceiling your uploads get, and this is an upload service: an
|
|
oversized upload is rejected by the proxy before Zipline sees a byte, the
|
|
user gets the Gateway's error instead of a message from the application, and
|
|
nothing says a chart value was ignored. Set the limit at the Gateway or
|
|
through its implementation's own policy object, next to the Gateway and not
|
|
here.
|
|
{{- else }}
|
|
config.maxUploadFileSize ({{ .Values.config.maxUploadFileSize }}) is rendered nowhere in this release: it exists
|
|
only as an ingress-nginx annotation, and neither routing mode is on.
|
|
Whatever proxy you put in front needs its own body-size limit.
|
|
{{- end }}
|
|
|
|
CHUNKS GO THROUGH /tmp, AND /tmp IS ACCOUNTED FOR
|
|
The root filesystem is read-only, so /tmp is an emptyDir — and an emptyDir
|
|
counts against the container's ephemeral-storage limit ({{ $eph }}).
|
|
An upload that pushes it over does not fail as a request: the kubelet evicts
|
|
the whole pod, and the reason is on the pod, not in Zipline's log. Where
|
|
uploads approach the 500mb the app allows, raise
|
|
zipline.resources.requests.ephemeralStorage — the limit follows it through
|
|
zipline.resources.limitFactor.
|
|
|
|
THE UPLOADS VOLUME BELONGS TO THIS RELEASE
|
|
uploads, public and themes share one PersistentVolumeClaim,
|
|
{{ .Release.Name }}-{{ .Chart.Name }}-vc ({{ .Values.config.storage }} from storageClass {{ .Values.config.storageClass }}), each on its own
|
|
subPath. It is an ordinary PVC in this release, not a StatefulSet
|
|
volumeClaimTemplate: "helm uninstall {{ .Release.Name }}" deletes it, and with a Delete
|
|
reclaim policy every uploaded file goes with it. Back the volume up before
|
|
uninstalling; a resource-policy annotation added to the live PVC afterwards
|
|
does not help, because Helm reads that annotation from the release manifest.
|
|
|
|
Growing config.storage only takes effect if the StorageClass allows volume
|
|
expansion. Shrinking it is refused by Kubernetes and makes the next
|
|
helm upgrade fail on the PVC instead of touching the data.
|
|
{{- if gt (atoi $replicas) 1 }}
|
|
|
|
MORE THAN ONE REPLICA WILL NOT COME UP
|
|
zipline.replicas is {{ $replicas }}, but every replica mounts the same
|
|
ReadWriteOnce claim {{ .Release.Name }}-{{ .Chart.Name }}-vc — there is no volumeClaimTemplate and no
|
|
per-pod volume. Unless the storage class hands that claim to several nodes,
|
|
the additional pods stay stuck before start. This chart is built for one
|
|
replica.
|
|
{{- end }}
|
|
{{- if .Values.zipline.env }}
|
|
|
|
zipline.env IS APPENDED, NOT MERGED
|
|
The entries land after the variables the chart sets itself — DATABASE_URL,
|
|
CORE_DEFAULT_DOMAIN, CORE_SECRET and UPLOADER_ADMIN_LIMIT — and are rendered
|
|
through tpl, so a value may contain template expressions. Anything sensitive
|
|
belongs in valueFrom.secretKeyRef: a plain "value" is stored in the pod spec
|
|
and readable by everyone who can read pods in {{ .Release.Namespace }}.
|
|
{{- end }}
|