Establish the flexible ingress standard from #32 in template-chart and document it in README/CLAUDE.md: ingress.domain and ingress.clusterIssuer stay required, new ingress.className value (default nginx) replaces the hardcoded ingressClassName, new optional ingress.annotations are merged with the cert-manager cluster-issuer annotation, TLS secret name unchanged (tls-<release>-<chart>-ingress). Apply the standard to cyberchef and patchmon (the two charts without an own batch-3 major PR) and make the patchmon probes values-configurable (server + guacd, rendered through tpl so the default Host header keeps following ingress.domain). Defaults render semantically identical to the previous hardcoded output. cyberchef 5.0.1 -> 5.1.0, patchmon 5.0.1 -> 5.1.0 (minor, additive).
5.7 KiB
CLAUDE.md
This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
Working on issues — mandatory workflow
The main Claude session acts as the task manager and does not implement issues itself:
- Plan first, get approval: The manager presents a plan for the issue and waits for the user's explicit approval. No implementation before approval.
- Document the final plan on the issue: Once approved, the plan is posted as a comment on the GitHub issue before implementation starts (skip if the issue body already contains the full plan; later decisions go there as comments too).
- Delegate implementation: After approval, the manager launches a dedicated development agent. The agent implements the issue completely on its own branch and opens a PR.
- PR comment handling by the agent: After opening the PR, the development agent watches it for review comments. New comments are addressed automatically (code changes, reply on the thread), and addressed threads are marked as resolved.
- Agent lifetime: The development agent terminates itself once its PR has been merged (or closed).
- Only after the PR has been merged by the user may work on the next issue begin. The user merges; never merge yourself.
- After the merge, verify the linked issue was closed (auto-close via "Fixes #n"); close it manually if not.
Additional rules for all commits, PRs, issues, and comments:
- Do not add a
Co-Authored-Bytrailer and do not append "Generated with Claude Code" footers.
Keep the docs current
- Changes to this issue workflow always go into this CLAUDE.md file.
- General repository information (charts, CI pipelines, conventions, tooling) always lives in README.md. Any PR that changes repo-wide behavior must update README.md in the same PR.
- Runtime verification of chart changes is done in a local, throwaway k3d cluster (k3d is installed on the maintainer's machine): stub CRD for
OnePasswordItem, dummy secrets, throwaway infrastructure (postgres/redis) where needed.
What this repo is
A collection of self-made Helm charts, one directory per chart, published to a private OCI registry via GitHub Actions. Validation happens on three levels: locally with Helm, in the PR pipeline (validate-charts.yml: strict lint, package, version-bump check), and in the PR install-test stage (k3d, fixtures under ci/ — see README):
helm lint --strict <chart-name>
helm template <chart-name> --set ingress.domain=example.com --set ingress.clusterIssuer=letsencrypt # render locally; required values vary per chart
Creating a new chart
Copy template-chart/ and replace every xxx placeholder — in file names (templates/xxx.deployment.yaml → templates/<app>.deployment.yaml), in Chart.yaml, and in the values.yaml keys and their .Values.xxx.* references inside templates. Then wire up CI:
- Add
.github/workflows/publish-<chart-name>.yml(copy an existing one, e.g.publish-outline.yml) — it triggers on pushes tomaintouching<chart-name>/**and calls the reusablepublish-helm-chart.yml. - Add the chart name to the
chart-namechoice list in.github/workflows/change-app-version.yml. - Add install-test fixtures under
ci/<chart-name>/(test-values.yaml,fixtures.yaml) or an entry with justification inci/excluded-charts.txt— the PR install-test fails if both are missing.
Versioning scheme
Chart.yaml versions follow version: <chart-semver>+up<appVersion> (e.g. 1.4.0+up1.9.2), with appVersion matching the suffix (dashes in the app version are normalized to dots in the suffix). Any push to main touching a chart directory publishes that chart, so the version must be bumped in the same change.
Semver conventions for the chart part:
- Patch: bug fixes without behavior or values-schema change.
- Minor: additive, backward-compatible changes (new optional values with unchanged defaults).
- Major: runtime behavior changes or breaking values changes (e.g. probes, security hardening, computed limits).
App-version updates go through PRs (so the validate and install-test pipelines run), not through the change-app-version.yml dispatch workflow (which commits directly to main and bypasses both). For app major jumps, update stepwise: first to the last release of the old major line (own PR, merge, publish), then to the newest major.
Chart conventions (from template-chart)
- All resources are named
{{ .Release.Name }}-{{ .Chart.Name }}-<kind>(e.g....-deployment,...-service,...-secret). - Image tags come from
{{ .Chart.AppVersion }}. - Secrets are 1Password
OnePasswordItemCRs: values exposesecrets.<name>SecretRefholding anop://item path; the operator materializes the Kubernetes Secret. - Ingress standard:
ingress.domainandingress.clusterIssuer(cert-manager) arerequiredvalues;ingress.classNamedefaults tonginx; optionalingress.annotationsare merged with the cert-manager annotation; TLS secret namedtls-<release>-<chart>-ingress. enventries in values support Helm templating — the deployment renders them throughtpl, and supportsvalue,secretKeyRef, andconfigMapKeyRefforms.- Hardened defaults:
automountServiceAccountToken: false, non-root user,readOnlyRootFilesystem: true, all capabilities dropped; probes and resource requests/limits always set. Security contexts are values-configurable (securityContext.pod/securityContext.container); image-forced deviations are documented with a comment in the chart'svalues.yaml. - Stateful apps use a StatefulSet in a
<app>.sfs.yamltemplate instead of a deployment. - No chart has dependencies;
charts/directories are empty.