Validate Helm Charts / Detect changed charts (pull_request) Successful in 4s
Validate Helm Charts / Resource quantities (pull_request) Successful in 14s
Validate Helm Charts / Selector match (pull_request) Successful in 14s
Validate Helm Charts / HTTPRoute match (pull_request) Successful in 14s
Validate Helm Charts / Build freesailarr (pull_request) Successful in 7s
Validate Helm Charts / Build outline (pull_request) Successful in 7s
Validate Helm Charts / Build paperless-ngx (pull_request) Successful in 8s
Validate Helm Charts / Build zipline (pull_request) Successful in 8s
Validate Helm Charts / Build calibre-web-automated (pull_request) Successful in 7s
Validate Helm Charts / Trivy config calibre-web-automated (pull_request) Successful in 19s
Validate Helm Charts / Trivy config freesailarr (pull_request) Successful in 24s
Validate Helm Charts / Trivy config outline (pull_request) Successful in 17s
Validate Helm Charts / Trivy config paperless-ngx (pull_request) Successful in 19s
Validate Helm Charts / Trivy config zipline (pull_request) Successful in 19s
Install-test / Install-test calibre-web-automated (pull_request) Successful in 2m11s
Install-test / Install-test freesailarr (pull_request) Successful in 3m55s
Install-test / Install-test outline (pull_request) Successful in 2m44s
Install-test / Install-test paperless-ngx (pull_request) Successful in 3m52s
Install-test / Install-test zipline (pull_request) Successful in 2m6s
Validate Helm Charts / Install-test (pull_request) Successful in 14m50s
Group 2 of the #114 sweep: the charts whose behaviour hangs off an nginx annotation - calibre-web-automated, outline, paperless-ngx, zipline (proxy-body-size) and freesailarr (rewrite-target). Each gets the form the pilot (cyberchef, PR #115) fixed and group 1 (PR #116) repeated: an httpRoute block off by default, a template rendering ONLY an HTTPRoute with parentRefs - no Gateway, no gatewayClassName, no Certificate, no implementation-specific policy object - render aborts on both modes at once (naming both value paths), on an empty parentRefs and on a missing hostname, empty hostnames meaning [ingress.domain], a schema entry closed against unknown keys with an open parentRef definition, and a NOTES.txt that names the active mode and what the mode costs. Minor, additive, defaults unchanged: `helm template` with each chart's CI values is byte-identical to origin/main for all five. The upload limit is DOCUMENTED, not rebuilt (decision 2 of the issue). The Gateway API knows no body size; a policy object would bind the chart to one implementation. So the Gateway branch of NOTES.txt says, per chart and in the chart's own terms, that the value is NOT ENFORCED and names where to set it: an e-book library (calibre), an upload service (zipline), the web-UI half of the document intake while the consume directory keeps no limit at all (paperless), and the open #12 pair (outline). Four findings that were not in the plan, each argued in the file it changes: freesailarr gated freesailarr.sharedIngressApps on ingress.enabled, and that list is read by the <APP>__SERVER__URLBASE variables as well as by the routing objects. In Gateway mode it would have come out EMPTY while the route served radarr, sonarr and prowlarr under their prefixes: UrlBase unset, assets and API calls linked at the host root, broken UI behind a Ready pod. The helper's two guards (seerr/mediathekarr only at "/", no duplicate paths) would have gone unenforced there too. Fixed with freesailarr.published (ingress.enabled OR httpRoute.enabled) - the same shape as sure.publishedOverTls in group 1, and identical to ingress.enabled while httpRoute.enabled is false. Measured: on origin/main with ingress.enabled: false the render emits ZERO URLBASE variables; with this change in Gateway mode it emits three. paperless-ngx was the last chart in the repository rendering its Ingress UNCONDITIONALLY. Without an ingress.enabled switch there is no second value path for the mutual-exclusion abort to name, and the Ingress plus its unconditional required() on clusterIssuer would have kept rendering in Gateway mode - a value demanded for nothing, which is issue #114's "Folge 1" and README guideline 12. The switch was added, defaulting to true, so the render is unchanged. paperless-ngx PAPERLESS_URL had no required() of its own: it relied on the Ingress template's, which stops firing the moment the Ingress is switchable. With httpRoute.hostnames set and ingress.domain empty it would have rendered "https://" and refused every login POST as a CSRF failure. It now carries its own required(), naming what the value is for. calibre-web-automated claimed, in values.yaml and in its schema, that ingress.domain is read nowhere but in the Ingress template. The HTTPRoute reads it, so the claim now holds only while both modes are off. Corrected rather than left standing - the same correction garage needed in group 1. freesailarr is where the Gateway API is LESS machinery than what it replaces, not a translation of it. rewrite-target applies per Ingress OBJECT, so qBittorrent (no base path, prefix must be stripped) needed a second Ingress on the shared host, which then had to repeat the first object's TLS secret name, omit the cert-manager annotation conditionally so only one Certificate is requested, and match an ImplementationSpecific regex path for the rewrite's capture group. A URLRewrite filter applies per RULE: one route, one rule per app, the filter on qBittorrent's rule, a plain PathPrefix. All four crutches gone. It is also the only chart without httpRoute.hostnames - it has no ingress.domain either, and a chart-global hostname list could not say which of the ten apps it belonged to, so the hostnames stay in ingress.host and <app>.ingress.host. CI: one render overlay per chart under ci/httproute/, so the assertion is not vacuum-green - ci/run-httproute-match-test.sh goes from 20 held assertions over 10 charts to 36 over 15. freesailarr's overlay moves bazarr onto a host of its own, so the shared-host route AND the per-app route are both rendered; without that the per-app branch would be exercised by nothing. The install-test fixtures stay in Ingress mode: the install runs one configuration per chart, cyberchef already pays that price against the real Gateway-API CRDs, and for paperless-ngx that fixture is the only install of the valkey-subchart path anywhere. README also carries a stale figure fixed here: the HTTPRoute test was still documented at the pilot's 4 assertions over 2 charts, although group 1 had taken it to 20 over 10. Not proven, by construction: that traffic flows. No Gateway controller runs in CI. Not run locally either: k3d, Docker, Trivy. The Gateway branch of NOTES.txt is EXECUTED by the render test (a template error in it fails the job, verified) but its text is printed by no pipeline stage - helm template does not emit notes, and the install-test installs in Ingress mode. Part of #114
189 lines
10 KiB
YAML
189 lines
10 KiB
YAML
{{/*
|
|
The Gateway-API alternative to freesailarr.ingress.yaml (Gitea #114). Form and
|
|
reasoning: template-chart/templates/xxx.httproute.yaml and README, "Ingress and
|
|
Gateway API".
|
|
|
|
Only HTTPRoutes with parentRefs. No Gateway, no gatewayClassName, no
|
|
Certificate, and no implementation-specific policy object - that subset looks
|
|
identical on nginx-gateway-fabric, Cilium, Envoy Gateway and Istio, which is
|
|
the whole reason the cluster's implementation can be swapped without touching
|
|
this chart. Class and certificate therefore belong to the PLATFORM, on the
|
|
Gateway and its listeners. ingress.clusterIssuer, ingress.className,
|
|
ingress.annotations and their per-app overrides are all inert in this mode.
|
|
|
|
THE SAME TWO SHAPES AS THE INGRESS, AND THEY STILL MIX
|
|
|
|
1. One host per app (the default): every published app gets its own
|
|
HTTPRoute with its own hostname, pointing at its own app's Service.
|
|
2. One shared domain with sub-paths (ingress.host): the apps that carry no
|
|
host of their own move into ONE route with one rule each.
|
|
|
|
THIS CHART HAS NO ingress.domain, SO httpRoute HAS NO hostnames
|
|
|
|
It is the documented exception on that point (README, guideline 4): the chart
|
|
bundles ten independently exposed apps, so there is no single hostname to put
|
|
in a chart-global list - a hostnames entry could not say which app it belonged
|
|
to. The hostnames therefore come from the values that already hold them,
|
|
ingress.host and <app>.ingress.host, which keeps the single source of truth the
|
|
convention is actually about. Those two are not Ingress switches: they name the
|
|
public addresses of this release, and both modes read them.
|
|
|
|
Consequence for a migration: the "second hostname" the convention offers
|
|
elsewhere is done here by changing <app>.ingress.host, which in Gateway mode
|
|
feeds only the route - there is no Ingress rendered to disagree with it.
|
|
|
|
WHERE THE GATEWAY API IS BETTER THAN WHAT IT REPLACES, AND IT IS NOT A
|
|
TRANSLATION
|
|
|
|
qBittorrent has no base-path setting: it serves its WebUI at the root and the
|
|
proxy has to strip the prefix. nginx applies rewrite-target per INGRESS OBJECT
|
|
and not per path, and the other apps must NOT be rewritten - their UrlBase
|
|
contains the prefix, so they expect the full path. That is why
|
|
freesailarr.ingress.yaml splits qBittorrent into a SECOND Ingress object on the
|
|
same host, which then has to
|
|
|
|
- repeat the same TLS secret name as the main object, so that neither object
|
|
depends on an assumption about whether nginx applies the other one's TLS
|
|
configuration to its paths,
|
|
- OMIT the cert-manager annotation so only one Certificate is requested for
|
|
that one secret - except when no main object renders at all, which is a
|
|
conditional inside the annotation block, and
|
|
- match on an ImplementationSpecific path with a regex
|
|
("<path>(/|$)(.*)") whose capture group 2 the rewrite refers to.
|
|
|
|
The Gateway API's URLRewrite filter is per RULE. All of that disappears: one
|
|
route, one rule per app, and qBittorrent's rule carries the filter while its
|
|
neighbours do not. The path match goes back to a plain PathPrefix, there is no
|
|
second object, no duplicated TLS block, no conditional annotation and no
|
|
regex. The convention's own summary says rewrite-target "has a real
|
|
equivalent"; in this chart the equivalent is strictly less machinery than the
|
|
original, and that is the reason this chart was worth converting rather than
|
|
merely translating.
|
|
|
|
WHAT IS NOT BETTER: ANYTHING THAT WAS AN ANNOTATION AND IS NOT A FILTER. The
|
|
per-app and global ingress.annotations have no counterpart at all here. This
|
|
chart sets no body-size annotation of its own, so nothing it NEEDS is lost -
|
|
but an operator who added one through ingress.annotations (qBittorrent takes
|
|
torrent file uploads) loses it silently in this mode. NOTES.txt says so.
|
|
*/}}
|
|
{{- /*
|
|
Null-safe like every other block this chart dereferences (#99): an override
|
|
written without children - "httpRoute:" with the keys below it deleted - is
|
|
YAML null, and `.Values.httpRoute.enabled` would abort the render with a nil
|
|
pointer. An empty block means "chart defaults apply", and both defaults are
|
|
empty or false, so the whole block collapses to "no HTTPRoute".
|
|
*/ -}}
|
|
{{- $httpRoute := .Values.httpRoute | default dict -}}
|
|
{{- if and $httpRoute.enabled .Values.ingress.enabled -}}
|
|
{{- fail "ingress.enabled and httpRoute.enabled are both true - set exactly one of them. The Ingresses and the HTTPRoutes would publish the same Services under the same hostnames over two different data paths, which is already a conflict at DNS level: one name, two addresses, and which one a client reaches is luck. ingress.enabled is this chart's MASTER switch and defaults to true, so turning the Gateway mode on means setting ingress.enabled: false in the same values file. A migration runs over different hostnames (change ingress.host or <app>.ingress.host), never over parallel operation of both modes." -}}
|
|
{{- end -}}
|
|
{{- if $httpRoute.enabled -}}
|
|
{{- $parentRefs := $httpRoute.parentRefs | default list -}}
|
|
{{- if not $parentRefs -}}
|
|
{{- fail "httpRoute.enabled is true but httpRoute.parentRefs is empty - an HTTPRoute without a parent attaches to no Gateway. It is created, it is schema-valid, and it routes NOTHING, with no event and no condition that says so; the only symptom is a hostname that does not answer. Name the cluster's Gateway, e.g. httpRoute.parentRefs: [{name: public, namespace: gateway}]." -}}
|
|
{{- end -}}
|
|
{{- $sharedHost := .Values.ingress.host | default "" }}
|
|
{{- /* The same validated list the Ingress uses, and the same list the UrlBase
|
|
env vars read: it is gated on freesailarr.published, so it is populated
|
|
in this mode as well. Its two guards - seerr/mediathekarr only at "/",
|
|
no duplicate paths on the shared host - therefore apply here unchanged,
|
|
which is the whole reason they live in the helper. */}}
|
|
{{- $shared := include "freesailarr.sharedIngressApps" $ | fromJsonArray }}
|
|
{{- range $app := include "freesailarr.ingressApps" $ | fromJsonArray }}
|
|
{{- $config := (index $.Values $app.name).ingress }}
|
|
{{- /* Skip the apps that live on the shared domain; they are one rule each in
|
|
the single route below. */}}
|
|
{{- if or (not $sharedHost) ($config.host | default "") }}
|
|
{{- $host := required (printf "%s.ingress.host must be provided while %s.ingress.enabled is true (or set the shared ingress.host to serve the app under a sub-path instead). The value is the app's public hostname and is read in Gateway mode as well - it is not an Ingress switch." $app.name $app.name) $config.host }}
|
|
---
|
|
apiVersion: gateway.networking.k8s.io/v1
|
|
kind: HTTPRoute
|
|
metadata:
|
|
name: {{ $.Release.Name }}-{{ $.Chart.Name }}-{{ $app.name }}-httproute
|
|
spec:
|
|
parentRefs:
|
|
{{- toYaml $parentRefs | nindent 4 }}
|
|
hostnames:
|
|
- {{ $host | quote }}
|
|
rules:
|
|
{{- /* The Ingress counterpart is `path: / , pathType: Prefix` on this
|
|
app's own Service. An app on a host of its own is served at the
|
|
root, so no rewrite is involved in either mode - that question only
|
|
arises under the shared host below.
|
|
|
|
The port is the Service's port NUMBER and not its name (the Ingress
|
|
addresses it by name, which is the app name): backendRefs takes a
|
|
PortNumber, so this reference cannot be made by name and the number
|
|
has to track freesailarr.service.yaml. Both come from
|
|
freesailarr.portApps, which is also what the Service renders from,
|
|
so they cannot drift - and
|
|
ci/run-httproute-match-test.sh fails when a backendRef names a
|
|
Service, or a port, the same render does not create. */}}
|
|
- matches:
|
|
- path:
|
|
type: PathPrefix
|
|
value: /
|
|
backendRefs:
|
|
- name: {{ $.Release.Name }}-{{ $.Chart.Name }}-{{ $app.name }}-service
|
|
port: {{ int $app.port }}
|
|
{{- end }}
|
|
{{- end }}
|
|
{{- if $shared }}
|
|
{{/*
|
|
The shared-domain route: ONE object for every app under ingress.host, one rule
|
|
each, rendered only when at least one app actually contributes a path - so
|
|
switching every app off while leaving ingress.host set produces no object
|
|
rather than an empty one without rules.
|
|
|
|
qBittorrent is in here with the others, which is the difference to the Ingress:
|
|
its rule carries the URLRewrite filter that strips the prefix, and a filter in
|
|
the Gateway API belongs to a RULE. No second object, no repeated TLS secret, no
|
|
conditional cert-manager annotation, no regex path - see the header.
|
|
|
|
The rules come sorted by path length descending, as the Ingress paths do. The
|
|
Gateway API specifies matching precedence by longest path match independent of
|
|
order (and so does nginx), so this is about a deterministic, reviewable
|
|
rendering, not about matching behaviour.
|
|
*/}}
|
|
---
|
|
apiVersion: gateway.networking.k8s.io/v1
|
|
kind: HTTPRoute
|
|
metadata:
|
|
name: {{ .Release.Name }}-{{ .Chart.Name }}-httproute
|
|
spec:
|
|
parentRefs:
|
|
{{- toYaml $parentRefs | nindent 4 }}
|
|
hostnames:
|
|
- {{ $sharedHost | quote }}
|
|
rules:
|
|
{{- range $app := $shared }}
|
|
- matches:
|
|
- path:
|
|
type: PathPrefix
|
|
value: {{ $app.path | quote }}
|
|
{{- if eq $app.name "qbittorrent" }}
|
|
{{- /* qBittorrent has no base-path setting - it serves its WebUI at the
|
|
root, so the prefix has to be stripped
|
|
(https://github.com/qbittorrent/wiki/blob/master/NGINX-Reverse-Proxy-for-Web-UI.md).
|
|
ReplacePrefixMatch replaces exactly the PathPrefix matched above,
|
|
which is why the match must be a PathPrefix and not a regex.
|
|
|
|
The apps around it must NOT be rewritten: their UrlBase carries
|
|
the prefix, so they expect the full path. Under an Ingress that
|
|
made a second object unavoidable, because rewrite-target applies
|
|
per object; here the filter is scoped to this rule and the others
|
|
are untouched by construction. */}}
|
|
filters:
|
|
- type: URLRewrite
|
|
urlRewrite:
|
|
path:
|
|
type: ReplacePrefixMatch
|
|
replacePrefixMatch: /
|
|
{{- end }}
|
|
backendRefs:
|
|
- name: {{ $.Release.Name }}-{{ $.Chart.Name }}-{{ $app.name }}-service
|
|
port: {{ int $app.port }}
|
|
{{- end }}
|
|
{{- end }}
|
|
{{- end }}
|