Files
helm-charts/template-chart/templates/NOTES.txt
T
jklein 50f683776e
Validate Helm Charts / Detect changed charts (pull_request) Successful in 4s
Validate Helm Charts / Resource quantities (pull_request) Successful in 14s
Validate Helm Charts / HTTPRoute match (pull_request) Successful in 13s
Validate Helm Charts / Build cyberchef (pull_request) Successful in 6s
Validate Helm Charts / Trivy config cyberchef (pull_request) Successful in 18s
Validate Helm Charts / Build template-chart (pull_request) Successful in 7s
Validate Helm Charts / Trivy config template-chart (pull_request) Successful in 17s
Install-test / Install-test cyberchef (pull_request) Successful in 1m0s
Validate Helm Charts / Install-test (pull_request) Successful in 1m0s
Validate Helm Charts / Selector match (pull_request) Successful in 12s
feat(cyberchef): Gateway-API as an alternative to the Ingress (pilot)
The Gateway-API pilot of Gitea #114: one chart, the convention, the CI that
holds it. The remaining 20 charts follow in their own PRs.

The form, additive and off by default:

    httpRoute:
      enabled: false     # counterpart to ingress.enabled
      parentRefs: []     # the Gateway - a platform object
      hostnames: []      # empty = [ingress.domain]

Only HTTPRoute with parentRefs is rendered: no Gateway, no gatewayClassName,
no Certificate, and no implementation-specific policy object. That subset is
identical on nginx-gateway-fabric, Cilium, Envoy Gateway and Istio, which is
what lets the implementation be chosen later without touching the charts
again. Class and certificate move to the platform.

Four guards, all against silent failures:

  - mutually exclusive with ingress.enabled, with a render abort naming BOTH
    value paths. A migration runs over a second hostname, not in parallel.
  - parentRefs mandatory in Gateway mode, render abort on the empty list: a
    route without a parent is created, is schema-valid, and routes nothing.
  - hostnames empty means [ingress.domain], so the hostname has one source.
  - the mode is a VALUE, not auto-detection: .Capabilities.APIVersions is
    unreliable at template time and a missing CRD fails at install time.

ingress.clusterIssuer was already only read inside the Ingress template, so
the "conditionally required" half of #114 needed no change in this chart -
checked rather than assumed, and it has to be re-checked per chart in the
sweep.

CI, both halves, because neither covers the other:

  - the install-test installs cyberchef in GATEWAY mode against the REAL
    Gateway-API CRDs (standard channel v1.6.3, pinned and Renovate-tracked,
    applied --server-side). A schema-less stub would accept a malformed route
    and prove only that something was created. The Ingress path of this one
    chart is no longer installed; it is a built-in type that never routed in
    k3d anyway, and helm lint renders this chart's defaults - Ingress mode -
    on every PR.
  - ci/run-httproute-match-test.sh, over every chart on every PR: every
    backendRefs entry must name a Service, on a port, that the SAME render
    creates, and parentRefs must not be empty. The CRDs accept both of those
    mistakes, so the schema cannot catch them, and the only report would be a
    route status no controller writes in CI.

What stays unprovable, and is written down instead of implied: that traffic
flows. No Gateway controller runs in k3d.

Minor: additive with unchanged defaults, proven by an empty helm template
diff against origin/main for the default values.

Part of #114
2026-10-12 15:16:26 +00:00

197 lines
10 KiB
Plaintext

{{/*
NOTES.txt — the reference implementation for issue #43.
Copy this file with the rest of template-chart and replace every xxx: the
values paths (.Values.xxx.*), the helper prefix ("xxx.replicas") and the app
name in the headline, exactly as in the other template files. This comment
block renders nothing and is meant to be deleted along the way.
THE STANDARD THIS FILE IS MEASURED AGAINST. A NOTES.txt that repeats the
values is worthless - it is skimmed once after the first install and never
read again. Print what an operator would otherwise have to look up in the
templates: the rendered access URL, WHICH FIELDS the 1Password item has to
carry, the options that are actually active in THIS release, and the traps of
this chart. Keep it conditional on the values that are really set, so the
output describes the installation at hand instead of every possible one.
NEVER PUT A REAL DOMAIN IN HERE. The URL is rendered from
.Values.ingress.domain, so it comes from the operator's values and not from
the chart; where an example is unavoidable, use example.com.
Note for the copier: a NOTES.txt renders no Kubernetes object, so adding one
is purely additive - a MINOR bump, and safe to roll out at any time.
*/}}
{{- $replicas := include "xxx.replicas" (dict "scaleDown" .Values.scaleDown "replicas" .Values.xxx.replicas) -}}
{{- $httpRoute := .Values.httpRoute | default dict -}}
{{- $hostnames := $httpRoute.hostnames | default list -}}
{{- if not $hostnames -}}
{{- $hostnames = list .Values.ingress.domain -}}
{{- end -}}
xxx {{ .Chart.AppVersion }} — release {{ .Release.Name }} in namespace {{ .Release.Namespace }}.
{{- if .Values.ingress.enabled }}
ACCESS — INGRESS MODE (ingress.enabled: true, httpRoute.enabled: false)
https://{{ .Values.ingress.domain }}
The certificate is requested by cert-manager through the "{{ .Values.ingress.clusterIssuer }}"
cluster issuer. Until it has been issued the browser shows a warning; follow it with
kubectl -n {{ .Release.Namespace }} get certificate tls-{{ .Release.Name }}-{{ .Chart.Name }}-ingress
{{- else if $httpRoute.enabled }}
ACCESS — GATEWAY MODE (httpRoute.enabled: true, ingress.enabled: false)
{{- range $hostnames }}
https://{{ . }}
{{- end }}
This release renders an HTTPRoute ({{ .Release.Name }}-{{ .Chart.Name }}-httproute) and nothing else of
the routing path — no Gateway, no class, no Certificate. Three things
therefore belong to the cluster rather than to this chart, and the hostname
above does not answer while any of them is missing:
1. The Gateway-API CRDs — present, or this install would have failed.
2. The Gateway named in httpRoute.parentRefs
{{- range $httpRoute.parentRefs }}
{{ .name }}{{ if .namespace }} in namespace {{ .namespace }}{{ end }}{{ if .sectionName }}, listener {{ .sectionName }}{{ end }}
{{- end }}
must exist AND allow routes from namespace {{ .Release.Namespace }} in its
listener's allowedRoutes. A refused attachment shows up only in the
route's own status:
kubectl -n {{ .Release.Namespace }} get httproute {{ .Release.Name }}-{{ .Chart.Name }}-httproute -o yaml
"Accepted: True" and "ResolvedRefs: True" under status.parents[] is
what a working attachment looks like; an empty status means no
controller has looked at the route at all.
3. The certificate for the hostname, on the Gateway's listener.
ingress.clusterIssuer is NOT used in this mode and is not required —
this chart renders no Certificate here.
ingress.annotations is inert in this mode as well: the Gateway API has no
annotation channel. When you copy this chart, say here what that costs YOUR
app — an upload limit set through proxy-body-size has no Gateway-API
equivalent at all, so silence on this point means the operator gets the
Gateway's default and finds out from a proxy error message.
ingress.domain STAYS REQUIRED in this mode, and not only as the hostname
fallback: the env block in values.yaml reads it for NORMAL_ENV, which is why
that read carries a required() of its own. Check that per chart (README,
guideline 12, point 1) — in a chart where nothing outside the routing
templates reads it, httpRoute.hostnames can replace it entirely.
{{- else }}
ACCESS — NEITHER INGRESS NOR HTTPROUTE
ingress.enabled and httpRoute.enabled are both false, so this release has no
Ingress, no HTTPRoute and no certificate, and ingress.clusterIssuer is not
needed. ingress.domain STAYS REQUIRED even so: the env block in values.yaml
reads it for NORMAL_ENV, which is why that read carries a required() of its
own. Without it the workload would start with an empty address and nothing
would point at the mistake.
Reach the release inside the cluster with
kubectl -n {{ .Release.Namespace }} port-forward svc/{{ .Release.Name }}-{{ .Chart.Name }}-service 8080:80
and open http://localhost:8080.
{{- end }}
{{ if eq $replicas "0" }}
SCALED TO ZERO
{{ if .Values.scaleDown }}scaleDown: true{{ else }}xxx.replicas: 0{{ end }} — the workload runs with replicas: 0, so the endpoint
above does not answer until you set it back and upgrade again. PVC, Secret{{ if .Values.ingress.enabled }},
Service and Ingress stay in place, so the certificate is not re-issued.{{ else if $httpRoute.enabled }},
Service and HTTPRoute stay in place, so the route keeps pointing at a Service
with no endpoints — the Gateway then answers with an error of its own rather
than with nothing.{{ else }} and
Service stay in place.{{ end }}
{{ end }}
THE 1PASSWORD ITEM MUST CARRY THE FIELDS THE CHART READS
secrets.xxxSecretRef points at
{{ .Values.secrets.xxxSecretRef }}
The 1Password operator materializes that item as the Kubernetes Secret
{{ .Release.Name }}-{{ .Chart.Name }}-secret, with one Secret key per field of the item. So the
fields are not free-form: this chart reads the field
secretKey (values.yaml, env entry ENV_FROM_SECRET)
and an item without it leaves the container stuck in
CreateContainerConfigError. Watch the materialization with
kubectl -n {{ .Release.Namespace }} get onepassworditem {{ .Release.Name }}-{{ .Chart.Name }}-secret
kubectl -n {{ .Release.Namespace }} get secret {{ .Release.Name }}-{{ .Chart.Name }}-secret
When you copy this chart, list YOUR chart's fields here. This is the one
piece of information that is otherwise only findable by reading the
templates, and it is the reason this section exists.
CHANGING THE SECRET DOES NOT RESTART ANYTHING HERE
Neither editing the values inside the 1Password item nor repointing
secrets.xxxSecretRef at a different item rolls the pods: this chart stamps
checksum/config over the ConfigMap, but no checksum/secret-ref over the
rendered OnePasswordItem. Helm never sees a secret's content, so the content
case cannot be closed at all — but the ref case can, and a chart that needs
it adds the second annotation (README, "Config changes must restart the
workload"). Until then, after any secret change:
kubectl -n {{ .Release.Namespace }} rollout restart deployment/{{ .Release.Name }}-{{ .Chart.Name }}-deployment
CONFIGURATION
{{ .Release.Name }}-{{ .Chart.Name }}-configmap is mounted into the workload, and the pod template
carries checksum/config over it — so a changed ConfigMap really does roll the
pods. That annotation is not decoration: a subPath mount is never refreshed
by the kubelet, and most apps read their config only at start, so without it
a config change would apply to nothing while everything stayed green.
The hash is taken over the rendered ConfigMap, not over a timestamp: an
unchanged config yields an identical hash and the upgrade stays a no-op.
STORAGE
{{ .Release.Name }}-{{ .Chart.Name }}-pvc, {{ .Values.storage.amount }}, {{ if .Values.storage.storageClass }}storage class "{{ .Values.storage.storageClass }}"{{ else }}on the cluster's default storage class
(storage.storageClass is unset){{ end }}.
helm uninstall does NOT delete this PVC, which is deliberate — the data
survives a reinstall of the same release name. It also means a release
removed and recreated under a DIFFERENT name starts on an empty volume while
the old one keeps occupying space.
WHAT A GREEN POD PROVES
All three probes are HTTP GETs against "/" on the port named http. They
prove that something answers on that port — not that the application is
functional, and not that anything behind the Ingress works, because probes
go straight to the pod and never pass through it.
When you copy this chart, point the probes at a real health endpoint and
carry the probe's CONTEXT into the fallback defaults in _helpers.tpl, not
just its timings: a default that loses a port name, a Host header or an exec
command leaves the workload with a probe that cannot succeed.
THIS CHART IS A SCAFFOLD — IT IS NOT MEANT TO RUN
If you are reading this from an actual install of template-chart, three
things will keep it from becoming Ready, all of them on purpose:
- The image is the placeholder "ghcr.io/ORG/IMAGE:{{ .Chart.AppVersion }}" and does not
exist, so the pods stay in ImagePullBackOff. This is also why the chart
sits in ci/excluded-charts.txt and is never published.
- The chart renders BOTH a Deployment and a StatefulSet, as the two shapes
to choose between. Delete the one your app does not need; the Service
selects the Deployment's pods, so a stateful app has to move that selector
along with it.
- The env block in values.yaml demonstrates the three supported forms
(value, secretKeyRef, configMapKeyRef) — it is an example, not a working
configuration. Note in particular that ENV_FROM_CONFIGMAP names
"{{ .Release.Name }}-{{ .Chart.Name }}-config-map" while the ConfigMap this chart creates is
"{{ .Release.Name }}-{{ .Chart.Name }}-configmap": replace the whole block with your app's real
variables rather than repairing the example.
{{- if .Values.ingress.enabled }}
{{- with .Values.ingress.annotations }}
EXTRA INGRESS ANNOTATIONS ARE ACTIVE
{{- range $key, $value := . }}
{{ $key }}: {{ $value }}
{{- end }}
These are merged with the cert-manager cluster-issuer annotation the chart
always sets. Annotations are interpreted by the ingress controller, so a
misspelled key is silently ignored — it does not fail the render.
{{- end }}
{{- end }}