Commit Graph
2 Commits
Author SHA1 Message Date
jklein 232ecdfa05 samba: remove the unimplemented globalConfig value
samba.globalConfig has been part of values.yaml since the chart's first
commit but is read by no template. Setting it never had an effect.

Rather than implement it, the key is removed and the strict schema now
rejects it: additionalProperties is already false on the samba object, so
dropping the property turns a silently ignored key into a render-time
error.

Operationally inert: neither the cluster-smb fleet bundle nor the deployed
release's user-supplied values set the key -- it only ever appeared as the
chart's own null default.

Major, because a published value disappears and is now rejected.

Fixes #117
2026-08-23 21:59:20 +02:00
jklein 24d3366e8b samba: strict values.schema.json and null-safe hardening
No ingress gate: this chart has no Ingress at all (SMB and NetBIOS are
exposed via NodePort), and ingress.domain appears neither in its
templates nor in its values.

1. values.schema.json (#68): additionalProperties: false on every
   chart-owned object level, including the entries of the samba.shares
   list.

2. Null-safety for hardening, probes and resources (#99).

   This chart's hardening is a documented deviation forced by the
   ghcr.io/dockur/samba image, and the fallbacks reproduce it exactly
   instead of restoring the repo standard: no runAs* values (the
   entrypoint creates Unix users and smbd impersonates the share user per
   session, both requiring a root start), readOnlyRootFilesystem stays
   false (the entrypoint writes /etc/passwd, /etc/group, the healthcheck
   symlink and the Samba TDBs), and capabilities.add keeps the six
   entries a multi-user root file server needs. Restoring the standard
   here would stop the file server from working.

   The probes target the SMB TCP port directly, because SMB is not HTTP.

The users.conf / checksum-config limitation from #82 is untouched: Helm
never sees the Secret content, so it cannot be hashed, and the comment in
values.yaml documenting the manual rollout restart stays as it is.

Rendering with normal values is byte-identical to 5.0.0.
2026-08-23 21:39:49 +02:00