homeassistant: cover the secret reference, document the content gap
Home Assistant reads configuration.yaml, http-config.yaml and recorder-config.yaml from a 1Password-backed Secret, mounted with subPath. Two different gaps hide behind that, and only one of them can be closed. Repointing secrets.configSecretRef at a different vault item used to leave the running pod on the old configuration. That is now covered: the pod template carries checksum/secret-ref over the rendered OnePasswordItem. The annotation is named apart from checksum/config on purpose - it only promises that the config source changed, not the config itself - matching the pattern minecraft-server introduced. Changing the CONTENT of the item in the vault still does not restart anything, and cannot: Helm never sees the content, so there is nothing to hash. The operator's own auto-restart annotation is no way out either - onepassword- operator 1.12.0 enumerates exactly one workload type in its secret-update handler (appsv1.DeploymentList) and this workload is a StatefulSet, so the annotation would be a silent no-op advertising a guarantee it cannot keep. It is deliberately not set. values.yaml states the limitation and the manual rollout restart it requires; the README guideline records the operator finding, the annotation precedence trap, and the checksum/secret-ref pattern so neither is rediscovered the hard way. Major bump: runtime behavior changes - changing the secret reference now costs a restart. For this release the effect is preventive, since it currently runs at zero replicas via scaleDown.
This commit is contained in:
4 files changed
+49
-1
No files matched your search
@@ -122,5 +122,32 @@ core:
|
||||
# - config
|
||||
# - http-config
|
||||
# - recorder-config
|
||||
#
|
||||
# Changing the op:// path below IS covered: the StatefulSet carries a
|
||||
# checksum/secret-ref annotation over the rendered OnePasswordItem, so pointing
|
||||
# this value at a different vault item restarts the pod.
|
||||
#
|
||||
# Known limitation (#82): changing the CONTENT of that item in the vault does
|
||||
# NOT restart Home Assistant. The operator updates the Kubernetes Secret, but
|
||||
# the running pod keeps the old files - they are mounted with subPath, which the
|
||||
# kubelet never refreshes, and Home Assistant reads its configuration only at
|
||||
# start. The change then takes effect at some unrelated later restart, possibly
|
||||
# months afterwards, and a broken value surfaces long after the edit that caused
|
||||
# it. That is especially likely for this release, which is currently kept at
|
||||
# zero replicas via scaleDown: whoever brings it back up gets whatever the vault
|
||||
# holds at that moment.
|
||||
#
|
||||
# The checksum/config mechanism the other charts use cannot close this gap:
|
||||
# Helm never sees the content (the operator fills the Secret in-cluster after
|
||||
# rendering), so there is nothing to hash. The operator's own
|
||||
# "operator.1password.io/auto-restart" annotation does not close it either - it
|
||||
# only ever restarts Deployments, never StatefulSets. Verified against
|
||||
# onepassword-operator 1.12.0: pkg/onepassword/secret_update_handler.go lists
|
||||
# exactly one workload type (appsv1.DeploymentList), and the PR adding
|
||||
# StatefulSets is still open. Setting the annotation here would look like a fix
|
||||
# and do nothing, so this chart deliberately does not set it.
|
||||
#
|
||||
# After changing the item, restart Home Assistant by hand:
|
||||
# kubectl rollout restart statefulset <release>-homeassistant-sfs
|
||||
secrets:
|
||||
configSecretRef: null
|
||||
Reference in new issue
Block a user