From 232ecdfa050414c7167824c910fe63ae12e3279e Mon Sep 17 00:00:00 2001 From: jklein Date: Sun, 23 Aug 2026 21:59:20 +0200 Subject: [PATCH] samba: remove the unimplemented globalConfig value samba.globalConfig has been part of values.yaml since the chart's first commit but is read by no template. Setting it never had an effect. Rather than implement it, the key is removed and the strict schema now rejects it: additionalProperties is already false on the samba object, so dropping the property turns a silently ignored key into a render-time error. Operationally inert: neither the cluster-smb fleet bundle nor the deployed release's user-supplied values set the key -- it only ever appeared as the chart's own null default. Major, because a published value disappears and is now rejected. Fixes #117 --- samba/Chart.yaml | 2 +- samba/values.schema.json | 4 ---- samba/values.yaml | 1 - 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/samba/Chart.yaml b/samba/Chart.yaml index d1326ac..6dc73ba 100644 --- a/samba/Chart.yaml +++ b/samba/Chart.yaml @@ -5,6 +5,6 @@ icon: https://avatars.githubusercontent.com/u/13281359 type: application -version: 6.0.0+up4.23.10 +version: 7.0.0+up4.23.10 appVersion: 4.23.10 diff --git a/samba/values.schema.json b/samba/values.schema.json index b818fa6..2f128ce 100644 --- a/samba/values.schema.json +++ b/samba/values.schema.json @@ -82,10 +82,6 @@ "securityContext": { "$ref": "#/definitions/securityContext" }, - "globalConfig": { - "description": "Currently read by no template - see the note in the PR that introduced this schema. Kept allowed because it is part of the published values surface; whether it gets implemented or removed is a separate decision.", - "type": ["string", "null"] - }, "storageClass": { "type": ["string", "null"] } diff --git a/samba/values.yaml b/samba/values.yaml index 5ef358f..2e8fc92 100644 --- a/samba/values.yaml +++ b/samba/values.yaml @@ -95,5 +95,4 @@ samba: - SETGID - SETUID - globalConfig: null storageClass: longhorn