From 1e28d1a99286fcf6df5321940f151bc747c9520e Mon Sep 17 00:00:00 2001 From: Justin Klein Date: Mon, 19 Oct 2026 13:11:37 +0000 Subject: [PATCH] feat(satisfactory): networkPolicy.ingress.ambientMesh Gitea #143. Additive, default false, so the render is byte-identical to the previous release - proven by diffing both renders against origin/main rather than asserted. Switched on it adds 15008/TCP, ztunnel's HBONE tunnel, to the rule carrying the probe port, and - inside that rule's source-restricted branch - 169.254.7.127/32, the address the kubelet's probes arrive from once the pod is in the mesh. Ambient does not bypass NetworkPolicy enforcement, so without the port a pod whose namespace has joined the mesh is unreachable. The two halves are one value because the second is the one nobody thinks of: 15008 added by hand leaves a policy that passes review and drops every probe the first time probeSources is narrowed, and a pod that never becomes Ready reads as a broken application rather than as a policy. Minor, not major: additive value, unchanged default, unchanged render. Port half only: this chart offers no networkPolicy.probeSources - its probes put no packet on the network - so there is no redirected probe to allow and an ipBlock for one would match nothing while making the rule look like it did something. ci/run-networkpolicy-test.sh ties that exemption to the absence of probeSources, not to a chart name. --- satisfactory/Chart.yaml | 2 +- .../templates/satisfactory.networkpolicy.yaml | 35 ++++++++++++++++++ satisfactory/values.schema.json | 11 ++++++ satisfactory/values.yaml | 36 +++++++++++++++++++ 4 files changed, 83 insertions(+), 1 deletion(-) diff --git a/satisfactory/Chart.yaml b/satisfactory/Chart.yaml index d30ef8f..c6912e9 100644 --- a/satisfactory/Chart.yaml +++ b/satisfactory/Chart.yaml @@ -3,7 +3,7 @@ name: satisfactory description: A Helm chart to deploy a Satisfactory Gameserver on Kubernetes icon: https://raw.githubusercontent.com/wolveix/satisfactory-server/main/.github/logo.png type: application -version: 8.0.0+upv1.9.10 +version: 8.1.0+upv1.9.10 appVersion: "v1.9.10" maintainers: - name: jklein \ No newline at end of file diff --git a/satisfactory/templates/satisfactory.networkpolicy.yaml b/satisfactory/templates/satisfactory.networkpolicy.yaml index 4278d78..42d129f 100644 --- a/satisfactory/templates/satisfactory.networkpolicy.yaml +++ b/satisfactory/templates/satisfactory.networkpolicy.yaml @@ -57,6 +57,11 @@ every port here against the containerPorts of the pod spec this policy selects. */ -}} {{- if .Values.networkPolicy.enabled }} +{{- /* networkPolicy.ingress - the policy's INBOUND side, and not the same + thing as the top-level .Values.ingress (the Ingress object) - both match + a search for "ingress". */}} +{{- $npIngress := .Values.networkPolicy.ingress | default dict }} +{{- $ambientMesh := $npIngress.ambientMesh }} apiVersion: networking.k8s.io/v1 kind: NetworkPolicy metadata: @@ -98,4 +103,34 @@ spec: port: {{ include "satisfactory.formatNumber" .Values.server.gamePort }} - protocol: TCP port: {{ include "satisfactory.formatNumber" .Values.server.messagingPort }} + {{- if $ambientMesh }} + {{- /* networkPolicy.ingress.ambientMesh (Gitea #143). 15008/TCP is ztunnel's + HBONE tunnel, the port every inbound connection arrives on once the + namespace carries istio.io/dataplane-mode - ambient "does not and will + never bypass Kubernetes NetworkPolicy enforcement", so without it a pod + in the mesh is unreachable. + + It is the one port here that is NOT a containerPort of the selected pod + spec: ztunnel terminates it, not the application. ci/run-networkpolicy- + test.sh holds a NAMED exception for exactly this number, gated on exactly + this value, and proves on a second render that it stays the only such + port and that it is absent while the value is false. + + THE PORT HALF ONLY, and that is not an omission. Elsewhere this switch + also adds 169.254.7.127/32 as a probe source, because inside the mesh the + kubelet's probes are redirected away from the worker node's address. + This chart offers no networkPolicy.probeSources at all, so the rule + carrying the probe port is never restricted by source - and an + unrestricted rule needs no probe address. The chart's networkPolicy + block has nothing but enabled. Measured in the render: two exec probes + and one tcpSocket. + WHICH RULE IT JOINS: + the only rule this policy has, the one carrying the game and messaging + ports. + NOT MEASURED: that 15008 alone suffices comes from Istio's + documentation. Measured on this cluster is only which listeners ztunnel + opens. Provable at the first namespace to join the mesh; none has. */}} + - protocol: TCP + port: 15008 + {{- end }} {{- end }} diff --git a/satisfactory/values.schema.json b/satisfactory/values.schema.json index c34ae43..1b15f1c 100644 --- a/satisfactory/values.schema.json +++ b/satisfactory/values.schema.json @@ -14,6 +14,17 @@ "type": "object", "additionalProperties": false, "properties": { + "ingress": { + "description": "The policy's INBOUND side. Three names here overlap as substrings and are not the same thing: the top-level ingress is the Ingress OBJECT this chart renders, networkPolicy.ingress is this block, and networkPolicy.ingressController is the SOURCE SELECTOR for the ingress controller's pods - a SIBLING of this block and no part of it.", + "type": ["object", "null"], + "additionalProperties": false, + "properties": { + "ambientMesh": { + "description": "Opens the pod for Istio's ambient mesh; off by default and additive, so the render is byte-identical while it is false. Renders 15008/TCP inbound - ztunnel's HBONE tunnel, which ambient explicitly does not let bypass NetworkPolicy enforcement - AND, where probeSources is non-empty, 169.254.7.127/32 as an additional probe source, because inside the mesh the kubelet's probes are redirected away from the worker node's address. The two halves are inseparable on purpose: whoever opens 15008 by hand has not added the probe address, and the first narrowed probeSources then drops every probe, so the pod never becomes Ready and the symptom reads as a broken application rather than as a policy. Unproven in operation: that 15008 alone suffices comes from Istio's documentation, and no namespace of this cluster carries istio.io/dataplane-mode yet.", + "type": ["boolean", "null"] + } + } + }, "enabled": { "type": "boolean" } diff --git a/satisfactory/values.yaml b/satisfactory/values.yaml index b056b27..31fe972 100644 --- a/satisfactory/values.yaml +++ b/satisfactory/values.yaml @@ -185,3 +185,39 @@ networkPolicy: # as both - a TCP-only rule would be accepted and would drop half the game # traffic. enabled: true + + # The policy's INBOUND side. Mind the three names that overlap as substrings, + # because a search for "ingress" matches all of them and they are different + # things: + # + # ingress (top level) the Ingress OBJECT this chart + # renders - host, TLS, className + # networkPolicy.ingress this block: what the policy lets IN + # networkPolicy.ingressController the SOURCE SELECTOR for the ingress + # controller's pods. A SIBLING of this block + # and NO PART OF IT, despite the name. + ingress: + # Opens the pod for Istio's ambient mesh (Gitea #143). OFF by default and + # additive: while it is false this chart renders byte for byte as it did + # before the value existed. + # + # It renders 15008/TCP inbound - ztunnel's HBONE tunnel. Every inbound mesh + # connection arrives on it, and ambient "does not and will never bypass + # Kubernetes NetworkPolicy enforcement", so without this port a pod whose + # namespace has joined the mesh is unreachable. + # + # ONE HALF SHORTER THAN ELSEWHERE, deliberately. In other charts this switch + # also adds 169.254.7.127/32 as a probe source, because inside the mesh the + # kubelet's probes are redirected away from the worker node's address. This + # chart has no networkPolicy.probeSources at all, so the rule carrying the + # probe port is never restricted by source - and an unrestricted rule needs + # no probe address. An ipBlock for one would match nothing while making the + # rule look like it did something, which is the kind of strict-looking empty + # rule ci/run-networkpolicy-test.sh exists to catch; that script ties the + # exemption to the absence of probeSources rather than to a chart name. + # + # NOT PROVEN: that 15008 alone is enough comes from Istio's documentation; + # measured on this cluster is only which listeners ztunnel opens, and no + # namespace carries istio.io/dataplane-mode yet. + ambientMesh: false +